Open
Conversation
Contributor
|
Seems like you based your PR on the wrong branch, it includes changes to the Maybe instead of straight up refusing to close we could instead ask for a confirmation? It would seem pretty weird to a newcomer to just have its close refused because of that. |
Contributor
Author
|
What should that look like? Something like asking them to run On second thoughts this would be pretty useless since we could suggest running |
Qwerty-133
force-pushed
the
man-close
branch
3 times, most recently
from
d9e0a2f to
3c3508e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
?closecommand require a time duration when closing with a custom close message. The close command in its current state abruptly closes the thread if you enter an incorrect time duration, for example.